Taskstate constant #368
Merged
Taskstate constant #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Status Update the FirmwareTaskStatus method to return the the TaskState constant. This is to remove the FirmwareInstall prefix from the current FirmwareInstall* constants and to have a generic Task State type.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
+ Coverage 44.29% 44.40% +0.10%
==========================================
Files 61 61
Lines 5145 5155 +10
==========================================
+ Hits 2279 2289 +10
Misses 2610 2610
Partials 256 256 ☔ View full report in Codecov by Sentry. |
jakeschuurmans
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
Updates the
FirmwareTaskVerifierinterface and its implementations to return aconstant.TaskStatetype.Checklist